Skip to content

Conversation

@KingingWang
Copy link

@KingingWang KingingWang commented Dec 8, 2025

Allocate memory for learn_param dynamically and check for allocation failure.

Description

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KingingWang, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 83959c7

@KingingWang KingingWang mentioned this pull request Dec 8, 2025
3 tasks
@github-actions github-actions bot changed the title Change learn_param to dynamic allocation Change learn_param to dynamic allocation (AEGHB-1335) Dec 8, 2025
Allocate memory for learn_param dynamically and check for allocation failure.
@KingingWang KingingWang marked this pull request as draft December 9, 2025 13:25
@KingingWang KingingWang marked this pull request as draft December 9, 2025 13:25
@KingingWang KingingWang marked this pull request as draft December 9, 2025 13:25
@KingingWang KingingWang marked this pull request as draft December 9, 2025 13:25
@KingingWang KingingWang marked this pull request as draft December 9, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ir_learn bug (AEGHB-1333)

2 participants