Skip to content

feature(ili9341): Add alternative driver configuration for LCD ILI9341 (BSP-638) #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vvranjek
Copy link

This is an alternative driver option that works with some LCD displays. The same as in TFT_eSPI library here: https://github.com/Bodmer/TFT_eSPI/blob/5793878d24161c1ed23ccb136f8564f332506d53/TFT_Drivers/ILI9341_Init.h#L127

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title feature(ili9341): Add alternative driver configuration for LCD ILI9341 feature(ili9341): Add alternative driver configuration for LCD ILI9341 (BSP-638) Feb 21, 2025
@espzav
Copy link
Collaborator

espzav commented Mar 18, 2025

I think, this cannot be part of driver. User can use vendor_config for change initialization commands. It can by part of readme file or something like that.

@espzav
Copy link
Collaborator

espzav commented Jun 18, 2025

@vvranjek please, did you see my latest comment?

@vvranjek
Copy link
Author

vvranjek commented Jun 19, 2025

@espzav It's been a long time since I was working with this, I just wanted to contribute my findings. Here is my view on this: users probably can use vendor_config to use custom drivers config, but this is nothing custom, the LCD that I got works out-of-the-box with the code that I provided in PR, not with original driver. This is the driver for ili9341, but ili9341 apparently is being manufactured with different specs/config, thus the need for different/alternative drivers. Since we don't know any manufacturing codes or part numbers that would tell us which specific hardware it is, there is no other option but to have alternative versions of the driver and the user must use trial and error to find out which one works for them. I spent days figuring this out, that is why I shared the code. Arduino libs use the same approach with alternative driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants