Skip to content

Fix WiFiClientRxBuffer::fillBuffer() error, likely solves issue #2212 #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jeroen88 wants to merge 3 commits into from
Closed

Fix WiFiClientRxBuffer::fillBuffer() error, likely solves issue #2212 #2259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
851ceb5
Fix WiFiClientRxBuffer::fillBuffer() error in handing a negative res …
Jan 1, 2019
0af48f2
Add logging in fillBuffer() if allocation of buffer fails
Jan 1, 2019
8538ae1
Remove BLE subdirectory
Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/BLE
Open in desktop
Submodule BLE updated 2 files
+1 −1 library.properties
+2 −6 src/BLEDevice.cpp
10 changes: 8 additions & 2 deletions libraries/WiFi/src/WiFiClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ class WiFiClientRxBuffer {
{
if(!_buffer){
_buffer = (uint8_t *)malloc(_size);
if(!_buffer) {
_failed = true;
return 0;
}
}
if(_fill && _pos == _fill){
_fill = 0;
Expand All @@ -67,8 +71,10 @@ class WiFiClientRxBuffer {
return 0;
}
int res = recv(_fd, _buffer + _fill, _size - _fill, MSG_DONTWAIT);
if(res < 0 && errno != EWOULDBLOCK) {
_failed = true;
if(res < 0) {
if(errno != EWOULDBLOCK) {
_failed = true;
}
return 0;
}
_fill += res;
Expand Down