feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

i3water · 2025-06-06T02:59:42Z

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Description of Change

update wifiduinov2&wifiduino32s3 boards setting

Tests scenarios

All example codes were verified on the wifiduinov2&wifiduino32s3 board base on Arduino SDK v3.2.0, confirming functionality across different scenarios.

Related links

product link:
https://www.openjumper.com/doc/wifiduino-v2
https://www.openjumper.com/doc/wifiduino32s3

CLAassistant · 2025-06-06T02:59:47Z

All committers have signed the CLA.

github-actions · 2025-06-06T03:00:18Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"fix wifiduinov2&wifiduino32s3 build board error."`: summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message `"fix wifiduinov2(esp32c3) board setting"`: summary looks empty type/action looks empty the commit message `"fix wifiduinov2(esp32c3) cdc on boot default setting."`: summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message `"update wifiduinov2&wifiduino32s3 boards setting"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello i3water, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9097877

P-R-O-C-H-Y

PTAL on my comment.
Please also share the boards data sheets or links so I can confirm some settings.

boards.txt

P-R-O-C-H-Y · 2025-06-06T11:47:03Z

boards.txt

@@ -31513,23 +31513,26 @@ wifiduino32c3.build.target=esp
 wifiduino32c3.build.mcu=esp32c3
 wifiduino32c3.build.core=esp32
 wifiduino32c3.build.variant=wifiduinov2
-wifiduino32c3.build.board=WiFiduinoV2
+wifiduino32c3.build.board=WIFIDUINOV2
 wifiduino32c3.build.bootloader_addr=0x0

 wifiduino32c3.build.cdc_on_boot=0


To match the preferred (default) CDC mode.

Suggested change

wifiduino32c3.build.cdc_on_boot=0

wifiduino32c3.build.cdc_on_boot=1

Thanks, changed this in new commit

This have not changed. Please commit this :)

boards.txt

i3water · 2025-06-09T03:10:17Z

PTAL on my comment. Please also share the boards data sheets or links so I can confirm some settings.

Thank you very much for your patient inspection. I have updated the incorrect settings.

P-R-O-C-H-Y · 2025-06-09T10:25:45Z

boards.txt

-wifiduino32c3.build.partitions=default
+wifiduino32c3.build.flash_mode=dio
+wifiduino32c3.build.boot=dio
+wifiduino32c3.build.partitions=no_ota


Why not to keep the default partition as default? I suggest to keep it.

P-R-O-C-H-Y · 2025-06-09T10:27:38Z

boards.txt

 wifiduino32s3.menu.FlashSize.4M=4MB (32Mb)
 wifiduino32s3.menu.FlashSize.4M.build.flash_size=4MB


You can remove the 4MB option as it comes with 16MB or optional 8MB as per docs. Also the 32MB can be removed.

Suggested change

wifiduino32s3.menu.FlashSize.4M=4MB (32Mb)

wifiduino32s3.menu.FlashSize.4M.build.flash_size=4MB

P-R-O-C-H-Y · 2025-06-09T10:32:24Z

variants/wifiduino32s3/pins_arduino.h

+static const uint8_t SS = 41;
+static const uint8_t MOSI = 40;
+static const uint8_t MISO = 38;
+static const uint8_t SCK = 39;


Can you please double check those? I see pin 38 wrongly assigned here.

update wifiduinov2&wifiduino32s3 boards setting

1ecfd15

i3water requested a review from P-R-O-C-H-Y as a code owner June 6, 2025 02:59

i3water added 3 commits June 6, 2025 11:02

Merge branch 'master' into master

e327424

fix wifiduinov2&wifiduino32s3 build board error.

e6ca548

Merge branch 'master' of https://github.com/i3water/arduino-esp32

7c4bb86

i3water changed the title ~~update wifiduinov2&wifiduino32s3 boards setting~~ feat(boards): update wifiduinov2&wifiduino32s3 boards setting Jun 6, 2025

P-R-O-C-H-Y requested changes Jun 6, 2025

View reviewed changes

P-R-O-C-H-Y added Status: In Progress ⚠️ Issue is in progress Type: 3rd party Boards labels Jun 6, 2025

fix wifiduinov2(esp32c3) board setting

f1eaa80

fix wifiduinov2(esp32c3) cdc on boot default setting.

9097877

P-R-O-C-H-Y reviewed Jun 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

i3water commented Jun 6, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

P-R-O-C-H-Y left a comment •

edited

Loading

Uh oh!

Uh oh!

P-R-O-C-H-Y Jun 6, 2025

Uh oh!

i3water Jun 9, 2025

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Uh oh!

Uh oh!

i3water commented Jun 9, 2025

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Uh oh!

P-R-O-C-H-Y Jun 9, 2025 •

edited

Loading

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Uh oh!

Uh oh!

	wifiduino32c3.build.cdc_on_boot=0
	wifiduino32c3.build.cdc_on_boot=1

		wifiduino32s3.menu.FlashSize.4M=4MB (32Mb)
		wifiduino32s3.menu.FlashSize.4M.build.flash_size=4MB

feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

Are you sure you want to change the base?

feat(boards): update wifiduinov2&wifiduino32s3 boards setting #11440

Conversation

i3water commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Tests scenarios

Related links

Uh oh!

CLAassistant commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

P-R-O-C-H-Y left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

P-R-O-C-H-Y Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

i3water Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

i3water commented Jun 9, 2025

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

P-R-O-C-H-Y Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

P-R-O-C-H-Y Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

i3water commented Jun 6, 2025 •

edited

Loading

CLAassistant commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

P-R-O-C-H-Y left a comment •

edited

Loading

P-R-O-C-H-Y Jun 9, 2025 •

edited

Loading