Skip to content

feat(uart): Add function to invert hardware UART Tx line #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(uart): Add function to invert hardware UART Tx line #11428

wants to merge 2 commits into from
+52 −4

Conversation

asund
Copy link

@asund asund commented Jun 4, 2025

Description of Change

Adds a setTxInvert() to HardwareSerial and corresponding uartSetTxInvert to the HAL.

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with ESP32 and ESP32-S2 Board.
I added an untested implementation for the ESP32C6, ESP32H2, ESP32P4 platform in the HAL to reflect the different register name.

Related links

N/A

@asund
feat(uart): Add function to invert hardware UART Tx line
7db47ca 
Simply clone existing Rx functionality for Tx.
Allow granular control over both lines.
Avoid overloading HardwareSerial::begin() to change the bool invert parameter to a bitmask type.
Add an untested implementation for ESP32C6, ESP32H2, ESP32P4 that references the different register
naming on those chips.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello asund, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 948c485

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from SuGlider June 4, 2025 09:55
@P-R-O-C-H-Y P-R-O-C-H-Y added Peripheral: UART Status: Review needed Issue or PR is awaiting review labels Jun 4, 2025
@asund asund requested review from lucasssvaz, P-R-O-C-H-Y and a team as code owners June 4, 2025 13:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Test Results

 76 files   76 suites   12m 42s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 948c485.

@SuGlider SuGlider self-assigned this Jun 5, 2025
@SuGlider
Copy link
Collaborator

SuGlider commented Jun 5, 2025

This PR may need a few improvements based on how IDF 5.4.1 has changed UART driver.
@asund - do you mind if I commit changes over your PR?

@asund
Copy link
Author

asund commented Jun 5, 2025

This PR may need a few improvements based on how IDF 5.4.1 has changed UART driver. @asund - do you mind if I commit changes over your PR?

No problem at all. Let me know if there's anything I can do if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider Awaiting requested review from SuGlider

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz lucasssvaz is a code owner

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y P-R-O-C-H-Y is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@SuGlider SuGlider

Labels
Peripheral: UART Status: Review needed Issue or PR is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asund @SuGlider @P-R-O-C-H-Y