feat: add no-missing-link-fragments rule #380
Open
+643
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested changes
May 19, 2025
There was a problem hiding this comment.
Thank you for taking this up. This looks like a good start. I have added a few suggestions on documentation & few false postives. I think there are few more cases we should cover that MD051 handles as well:
-
HTML ids:
<a id="bookmark"></a> [Link](#bookmark) // valid
-
#top: HTML links to #top scroll to the top of a document.[Link](#top)
-
Custom fragment syntax used by GitHub to highlight specific content in a document.
[Link](#L20) // Valid [Link](#L19C5-L21C11) // Valid
snitin315
reviewed
May 19, 2025
SwetaTanwar
force-pushed
the
feat/no-missing-link-fragments
branch
from
67f7cc1 to
b051c1a
Compare
lumirlumir
requested changes
May 20, 2025
SwetaTanwar
commented
May 23, 2025
nzakas
reviewed
May 23, 2025
SwetaTanwar
force-pushed
the
feat/no-missing-link-fragments
branch
from
1301dba to
a36b406
Compare
lumirlumir
requested changes
May 26, 2025
|
@SwetaTanwar please double-check the merge conflict. |
nzakas
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR adds a new rule
no-missing-link-fragmentsto ensure there is no missing link fragment in the markdownWhat changes did you make? (Give an overview)
Added the
no-missing-link-fragmentsrule, along with documentation and tests.Related Issues
fixes #369
Is there anything you'd like reviewers to focus on?