feat: add url and recommended field to existing rules
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
May 22, 2025
….com/eslint/json into docs-add-url-field-to-existing-rules
lumirlumir
changed the title
url and recommended field to existing rules
|
I think it's fine to link to https://github.com/eslint/json#rules until we add dedicated docs. Can you also enable |
|
Thanks for the suggestions. I've added a new commit 85b1ea1 |
mdjermanovic
approved these changes
May 23, 2025
snitin315
approved these changes
May 28, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
In this PR, I've added the
urlfield to existing rules.The links reference the documentation shown in the screenshot below:
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?