Skip to content

chore: fix CI error related to prettier fmt #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Jun 25, 2025

Prerequisites checklist

What is the purpose of this pull request?

Hello,

This PR fixes the CI error related to Prettier's fmt command.

Currently, the CI fails on main branch.

image

The source of this error was an inconsistency between the old Prettier version and the newly released Prettier v3.6.0.

This PR fixes the following references:

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 25, 2025
@lumirlumir lumirlumir marked this pull request as ready for review June 25, 2025 06:45
@mdjermanovic
Copy link
Member

It might be worth reporting this as a potential bug in Prettier, as the rendering is different:

Without the blank line:

image

With the blank line:

image

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, let's merge this to fix CI. If and when this behavior changes in Prettier, we can add the blank line back.

@mdjermanovic mdjermanovic merged commit d6b2e3a into main Jun 25, 2025
22 checks passed
@mdjermanovic mdjermanovic deleted the chore-fix-ci-error-when-using-prettier-fmt branch June 25, 2025 09:53
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants