feat: add no-invalid-import-placement rule #156
Conversation
lumirlumir
added
the
accepted
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
Thanks for the PR, the code mostly LGTM. Just a few suggestions
| if (IGNORED_AT_RULES.has(name)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
It is not an invalid placement though?
| }, | ||
|
|
||
| Rule() { | ||
| hasSeenNonImportRule = true; |
There was a problem hiding this comment.
Should we set it to false again once the traversing is complete?
| recommended: true, | ||
| url: "https://github.com/eslint/css/blob/main/docs/rules/no-invalid-import-placement.md", | ||
| }, | ||
|
|
There was a problem hiding this comment.
Let's also add the ignoreAtRules option similar to https://stylelint.io/user-guide/rules/no-invalid-position-at-import-rule/#ignoreatrules?
There was a problem hiding this comment.
I considered it but didn’t find a need. Want it added anyway?
There was a problem hiding this comment.
yes, we should add it for easy migration.
There was a problem hiding this comment.
We've decided to expand no-invalid-import-placement to no-invalid-at-rule-placement. Given this change, should we rename the ignoreAtRules option to something more specific, like ignoreAtRulesForImport?
|
Superseded by #171 |
4 participants
Prerequisites checklist
What is the purpose of this pull request?
This pull request introduces a new rule
no-invalid-import-placementthat enforces correct placement of@importrules within stylesheets.What changes did you make? (Give an overview)
no-invalid-import-placementrule to enforce correct placement of@importrulesRelated Issues
Fixes #151
Is there anything you'd like reviewers to focus on?