execution/engineapi: reject engine_getBlobsV1 post-osaka#21857
Open
Sahil-4555 wants to merge 5 commits into
Open
execution/engineapi: reject engine_getBlobsV1 post-osaka#21857Sahil-4555 wants to merge 5 commits into
Sahil-4555 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Engine API blob-fetch endpoints to follow Osaka fork rules by rejecting engine_getBlobsV1 once Osaka is active and by short-circuiting engine_getBlobsV2/engine_getBlobsV3 to return null before Osaka to avoid unnecessary txpool work and log spam.
Changes:
- Add Osaka fork gating to
GetBlobsV1, returning-38005 Unsupported forkpost-Osaka. - Add pre-Osaka early-returns for
GetBlobsV2andGetBlobsV3(returnnullwithout querying the txpool).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sahil-4555
force-pushed
the
fix/engineapi-reject-getblobsv1-post-osaka
branch
from
July 10, 2026 09:39
ad54d0a to
08d9fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Engine API specifications, after the activation of the Osaka fork on the network we should no longer support the
engine_getBlobsV1method and it should return the-38005: Unsupported forkerror.To deal with this, I have added an additional check in GetBlobsV1 of EngineServer to check whether the current canonical head block’s timestamp has crossed the Osaka activation time or not. If active we are returning the
UnsupportedForkErrordirectly.Before, even after Osaka activation, calling
engine_getBlobsV1would still query the txpool and try to return single-element KZG proofs - that's the wrong behaviour post-Osaka where cell proofs (128 elements) are the norm. Now it immediately rejects with the required spec error.Add new test TestGetBlobsV1PostOsakaRejection to check GetBlobsV1 correctly returns -38005: Unsupported fork when Osaka is active.