fix(code-intel): remote-mode parity — local fallback, learning routing, startup dedup#92
Merged
Merged
Conversation
…g, startup dedup Task #5 follow-ups to the remote/local work: - regex_search / call_graph have no server-side HTTP route, so proxying them crashed with AttributeError in remote mode; they now run locally via a new _shared._get_local_service() that bypasses the remote proxy. - learning_tools (recall/record_learning/learning_feedback/list_learnings) were always local while adr_tools routed to remote — a split-brain where remote-mode learnings never reached the server. They now branch to the remote proxy like adr_tools. - server.main() and cli._cmd_serve() duplicated (and diverged on) the remote-enable wiring; extracted one shared _shared.enable_remote_if_configured() used by both. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-ups to the remote/local reliability work (#91, v0.2.24). These are the remaining remote-mode correctness gaps surfaced by the bug-hunt.
What changed
regex_searchandcall_graphhave no server-side HTTP route, so proxying them crashed withAttributeErrorin remote mode. They now run against the local index via a new_shared._get_local_service()that bypasses the remote proxy.learning_tools(recall / record_learning / learning_feedback / list_learnings) always ran local whileadr_toolsrouted to remote — so in remote mode, learnings never reached the server. They now branch to the remote proxy likeadr_tools.server.main()andcli._cmd_serve()duplicated (and had diverged on) the remote-enable wiring. Extracted one shared_shared.enable_remote_if_configured()used by both.Tests
test_remote_local_fallback.py(local fallback + learning routing + the shared startup helper).test_call_graph_tool.pyto patch the getter the tool now uses.test_deps/test_middlewareare unrelated — they fail identically onmain.)🤖 Generated with Claude Code