refactor: remove --detect-size option and simplify setLimit function

[equationzhao]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @equationzhao, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on simplifying the application's codebase by removing the --detect-size command-line option and streamlining the setLimit function. This change hardcodes the mimetype detection limit to a fixed value, reducing complexity and maintenance overhead associated with a configurable but potentially less utilized feature.

Highlights

• Feature Removal: The --detect-size command-line option has been completely removed from the application. This includes its flag definition, associated documentation in docs/man.md, and its presence in shell completion scripts for Bash, Fish, and Zsh.
• Code Simplification: The setLimit function has been significantly simplified. It no longer accepts a context parameter or returns an error. Instead, it now consistently sets the mimetype detection limit to a fixed 1MB (1024 * 1024 bytes), removing the previous configurability that --detect-size provided.
• Refactored Call Sites: All instances where setLimit was invoked, particularly within filtering, sorting, and viewing flag actions, have been updated to reflect its simplified signature. The util.Once mechanism (limitOnce.Do) previously used to ensure setLimit was called only once has also been removed, as it is no longer necessary with the simplified function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the codebase to remove the --detect-size command-line option, simplifying the logic by using a hardcoded value for the mimetype detection size limit. The changes are consistently applied across shell completion scripts, documentation, and Go source files. The util.Once wrapper for setting the limit has also been removed, which simplifies the code at various call sites.

The implementation is clean and achieves its goal. I have one suggestion to replace a magic number with a named constant to improve code readability and maintainability.

[gemini-code-assist]

The value 1024 * 1024 is a magic number. Using a named constant would improve readability by making it clear what this value represents (1 MiB) and would make it easier to modify in the future.

	const mimeDetectLimit = 1024 * 1024 // 1 MiB
	mimetype.SetLimit(mimeDetectLimit)