Skip to content

Conversation

@AntonKanug
Copy link
Contributor

@AntonKanug AntonKanug commented Jan 8, 2026

Follow up to #41385

Commit Message: dns_filter: make DNS format commands available at config initialization
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

Fixes listener initializing errors when using custom tag substitution for dns filter logs

delta config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) listener: Not supported field in StreamInfo: QUERY_NAME

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42915 was opened by AntonKanug.

see: more, trace.

@AntonKanug AntonKanug force-pushed the antonk/dns-logs-on-init branch 2 times, most recently from 18b765e to a903416 Compare January 8, 2026 23:48
@AntonKanug AntonKanug marked this pull request as ready for review January 9, 2026 10:25
@AntonKanug
Copy link
Contributor Author

cc @wbpcode

@AntonKanug AntonKanug force-pushed the antonk/dns-logs-on-init branch from 3252dd2 to 1d7ad8d Compare January 9, 2026 10:39
Signed-off-by: Anton Kanugalawattage <[email protected]>

u

Signed-off-by: Anton Kanugalawattage <[email protected]>

format

Signed-off-by: Anton Kanugalawattage <[email protected]>

test

Signed-off-by: Anton Kanugalawattage <[email protected]>

update

Signed-off-by: Anton Kanugalawattage <[email protected]>

u

Signed-off-by: Anton Kanugalawattage <[email protected]>
@AntonKanug AntonKanug force-pushed the antonk/dns-logs-on-init branch from 1d7ad8d to e3925b1 Compare January 9, 2026 12:39
@wbpcode
Copy link
Member

wbpcode commented Jan 11, 2026

Thanks for this contribution. But

  1. I think to configure DNS's related format in the listener make no sense anyway?
  2. We prefer only keep HTTP and TCP's format as built-in and to reduce the potential name conflict?

@AntonKanug
Copy link
Contributor Author

AntonKanug commented Jan 11, 2026

  1. I think to configure DNS's related format in the listener make no sense anyway?

We use a udp listener with dns filter (similar to this example)

  1. We prefer only keep HTTP and TCP's format as built-in and to reduce the potential name conflict?

whats the suggestion to fix envoy rejecting listener config due to command not being recognized in this case?

delta config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) listener: Not supported field in StreamInfo: QUERY_NAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants