Replaced Otto event bus library with RxJava event bus#941
Open
Akash-Ramjyothi wants to merge 1 commit intoenviroCar:gsoc2022from
Open
Replaced Otto event bus library with RxJava event bus#941Akash-Ramjyothi wants to merge 1 commit intoenviroCar:gsoc2022from
Akash-Ramjyothi wants to merge 1 commit intoenviroCar:gsoc2022from
Conversation
Contributor
Author
|
@asaikarthikeya please see my PR. |
Contributor
|
The introduced RxBus lib does not seem to be well maintained. What's the benefit of this lib over the Otto event bus library? If we depend on a library that won't be maintained well and maybe deprecated in the future, we do not win anything. What about other libs, such as greenrobot/EventBus? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #827.
Description: