-
Notifications
You must be signed in to change notification settings - Fork 1
1.0.0 Release Candidate #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release is a full rewrite of
nt2py.Key changes
Dataclass now relies on an externalBaseReaderclass (which can be inferred automatically or passed manually).BaseReaderis a pure virtual class which is then implemented by different format-specific classes, e.g.,hdf5.Readerandadios2.Reader. TheDataclass is completely agnostic to which reader is being used.BaseReadernow does a much better job reading (or skipping) corrupted files, while building its internal structure regardless of how many files were skipped.@dask.delayeddecorator for lazy loading.hdf5andadios2formats.To-do for the release
np.nanpaddings)support for the spectraNot-to-forget before the release