Skip to content

go/pubsub: handle nil static cfg#2297

Merged
fredr merged 1 commit intomainfrom
fredr/static-cfg-nil
Feb 23, 2026
Merged

go/pubsub: handle nil static cfg#2297
fredr merged 1 commit intomainfrom
fredr/static-cfg-nil

Conversation

@fredr
Copy link
Member

@fredr fredr commented Feb 23, 2026

No description provided.

@fredr fredr requested a review from eandre February 23, 2026 11:19
@fredr fredr self-assigned this Feb 23, 2026
@fredr fredr merged commit 94210c7 into main Feb 23, 2026
5 checks passed
@fredr fredr deleted the fredr/static-cfg-nil branch February 23, 2026 11:33
harryapp-eu pushed a commit to harryapp-eu/encore that referenced this pull request Feb 24, 2026
commit 94210c7
Author: Fredrik Enestad <fredrik@enestad.com>
Date:   Mon Feb 23 12:33:28 2026 +0100

    go/pubsub: handle nil static cfg (encoredev#2297)

commit cec8064
Author: Fredrik Enestad <fredrik@enestad.com>
Date:   Mon Feb 23 10:08:11 2026 +0100

    docs: Set prebuild and postbuild hooks default value (encoredev#2294)

    Updated prebuild and postbuild hooks to empty strings since that is the
    default value.

commit 68d48e8
Author: Fredrik Enestad <fredrik@enestad.com>
Date:   Mon Feb 23 09:58:53 2026 +0100

    tsparser: add missing uniqueness checks (encoredev#2295)

commit ec5e698
Author: Fredrik Enestad <fredrik@enestad.com>
Date:   Fri Feb 20 13:49:31 2026 +0100

    clientgen: fix optional arrays (encoredev#2271)

    Example using this type:
    ```ts
    export interface RequestType {
        foo?: SomeEnum[]
        bar?: boolean[]
    }
    ```
    Previously generated the following code, which will cause an error
    (`Type '(string | undefined)[] | undefined' is not assignable to type
    'string | string[] | undefined'.`) since it will make the element into
    `string | undefined`. But it is the field itself that is optional, not
    the element.
    ```ts
    const query = makeRecord<string, string | string[]>({
        bar: params.bar?.map((v) => v === undefined ? undefined : String(v)),
        foo: params.foo?.map((v) => v === undefined ? undefined : String(v)),
    })
    ```

    and with the fix the following code will be generated instead:

    ```ts
    const query = makeRecord<string, string | string[]>({
        bar: params.bar?.map((v) => String(v)),
        foo: params.foo?.map((v) => String(v)),
    })
    ```

commit daa7584
Author: Fredrik Enestad <fredrik@enestad.com>
Date:   Thu Feb 19 14:47:04 2026 +0100

    runtimes: add trace sampling config for endpoint/service (encoredev#2292)

commit a753066
Author: Simon Johansson <simon@encore.dev>
Date:   Wed Feb 18 10:23:09 2026 +0100

    Add GitHub templates for issues and discussions (encoredev#2291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants