fix: docker base image default value is now correctly displayed for both Go & TS#2260
Open
kcalbxof wants to merge 1 commit intoencoredev:mainfrom
Open
fix: docker base image default value is now correctly displayed for both Go & TS#2260kcalbxof wants to merge 1 commit intoencoredev:mainfrom
kcalbxof wants to merge 1 commit intoencoredev:mainfrom
Conversation
|
All committers have signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on my personal project, when i figured out that Encore uses "node:slim" as base image, rather than "
scratch", which led to encore docker container being unable to launch with TS code, when i used another base image. Thats understandable, just not clear from "help menu" provided in console:
Now it should say:
Just a heads up, i havent had experience with Go syntax yet, and that PR is rather compulsive... So please check thoroughly, and thanks for understanding.