Skip to content

[ci] Update 'latest' version of node to v24. NFC #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 30, 2025

We can now use this for testing wasm64 and esm integration.

@sbc100 sbc100 requested review from kripken and brendandahl May 30, 2025 16:34
@brendandahl
Copy link
Collaborator

Alternatively, instead of pinning it at 24, we could call this node-current and keep bumping it?

@sbc100
Copy link
Collaborator Author

sbc100 commented May 30, 2025

Alternatively, instead of pinning it at 24, we could call this node-current and keep bumping it?

The idea is that current is supposed to be LTS, which would be 22.16... that also needs updating :)

@sbc100
Copy link
Collaborator Author

sbc100 commented May 30, 2025

Oh wait.. I misread your comment. Will update.

@sbc100 sbc100 changed the title Use node v24 for testing wasm64 and esm integration. NFC [ci] Update 'latest' version of node to v24. NFC May 30, 2025
@sbc100
Copy link
Collaborator Author

sbc100 commented May 30, 2025

Done.

@sbc100 sbc100 enabled auto-merge (squash) May 30, 2025 17:53
@sbc100 sbc100 force-pushed the node24 branch 2 times, most recently from 650f2de to 066d677 Compare June 2, 2025 16:58
sbc100 added a commit that referenced this pull request Jun 2, 2025
The wasm64 tests modes already require this.

Split out from #24449
Also update wasm-esm-integration tests to require v24 rather than
canary.
@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 3, 2025

OK, #24471 and #24465 and #24463 are now all landed separately so this PR should now be much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants