-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Domain keys in map #14478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gldubc
wants to merge
13
commits into
elixir-lang:main
Choose a base branch
from
gldubc:domain-keys-in-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Domain keys in map #14478
+1,166
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced tests for union, intersection, and difference operations involving domain key types. - Validated subtype relationships and intersection results for maps with domain keys. - Enhanced map fetch and delete functionalities to handle domain key types. - Ensured correct behavior of dynamic types with domain keys in various scenarios.
…n_map_with_default to map_with_default and implement map_update functionality
I will lock this issue for now because of spam, will reopen once I have feedback. :( |
josevalim
reviewed
May 13, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
josevalim
reviewed
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows maps to encode domain keys, from paper https://www.irif.fr/~gc/papers/icfp23.pdf
For example, we can now express the type
%{a: integer(), b: float(), atom() => tuple()}
of maps that have keys:a
and:b
and any other atom key mapping to a tuple.Those are created by adding {{:domain_key, :atom}, type} pairs to constructors open_map or closed_map.
This introduces new operators:
map[key]
where key is some expression of some typeMap.put(map, key, type)
(not called map_put because the name is already used for adding a single key to a map. The difference here is that,key
being a type, we are not sure which key is being added).Both operators handle singleton atoms exactly. See the following tests:
Notes:
map_check_domain_keys(tag, neg_tag)
is very long to treat all the different cases optimally. It could be shortened to a single loop on all the possible domains, with default values.