-
Notifications
You must be signed in to change notification settings - Fork 22
Bazzite/Atomic Distro Support and Major Build System Overhaul #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 72cfa3a.
|
This is super cool! I am just trying to install this on my fresh bazzite instance. The install itself went well but the service doesn't run: Any idea what my problem is here? |
|
Hello @fcaraujo, I've recently replaced the way the app is being installed, essentially deprecating install.sh, introducing uv instead of pipenv (which was producing too many problems) and installing the app package-wise only. The current rehaul is available in the develop branch (btw this merge request points to main, but should point to develop, from which new releases are emerged) - it probably needs still some inter-distro code deduplication (essentially the steps of dependencies download and copy to dest dir are still being duplicated, which is never a good choice). Also the new packaging system preferes python packages dependencies, if available distro-side (for example Fedora's rpm is now down to ~500 KB). May you please adapt your installation changes, and explain me the key changes from an architectural point of view? Thanks :) |
Hey I also have a nova pro wireless and running on bazzite so when I got the project found some issues (some already opened) so I decided to give it a go and also fix them without being too much intrusive.
Later I'll add a more comprehensive list of changes here, but opening the PR now so at least you can wrap your head around and consider the changes.
Summary: identify if it's running on an atomic distro, avoid the annoying PEP668 errors, fix the service startup issues and customize icon for Hyprland/Waybar users (also identified the current theme so the settings screen) so my tray icon is light (added an optional configuration + the screen is dark themed).
This ended up turning into a full makefile install (improved workflow which replaced the *.sh script, but I didn't change mostly of the dependency management to keep the project as is and up to you if you wanna change later) + adding some dx and trying to make life easier for everyone.
Fully tested on Bazzite with
make installand uninstall, also during development you can usemake devso it reinstalls after built.