fix(asar): refactoring symlink check logic #9130
Open
+56
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
pnpm install
operates from the current subpackage's dir and considered as root (process.cwd()
), additional logic is needed that walks up the directory tree to find apnpm-workspace.yaml
orpackage.json
with monorepo configuration set. The "walk" functionality auto-stops when it detects a.git
folder to prevent unnecessary walking further up the directory tree.This finds the root of the monorepo to resolve dependencies from avoiding/instead of the
../
relative path trap from occurring.The interesting part is that the
better_sqlite3
file is not considered a symlink, even though the parent directory further up the tree is a symlink. The newasarUtil
logic is that it copies the.node
as a direct file since it itself is not a symlink, which allows the electron-builder packaging process to continueFixes #9025