[App Menu Standardization] Handle export funcionality #248556
Conversation
kowalczyk-krzysztof
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
3 times, most recently
from
b099a37 to
1ee1314
Compare
kowalczyk-krzysztof
changed the title
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
6 times, most recently
from
1772b5e to
f388ff2
Compare
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
from
f388ff2 to
d3630a5
Compare
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
| if ( | ||
| !derivative || | ||
| derivative.shareType !== 'integration' || | ||
| derivative.groupId !== 'exportDerivatives' | ||
| ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
it should be sufficient to check no derivative was found here
There was a problem hiding this comment.
Yeah this is redundant, changed. Thanks
| const exportIntegration = menuItems.find( | ||
| (item) => item.shareType === 'integration' && item.id === exportId | ||
| ); |
There was a problem hiding this comment.
Since export derivatives has it's own handler, do we want to exclude export derivatives here?
There was a problem hiding this comment.
That's true, changed the implementation to exclude derivatives. Thanks.
There was a problem hiding this comment.
Sorry man... I think I should have phrased the initial suggestion properly, it's best we specifically select for integrations of groupId export, especially that it's technically possible to have integrations have the same id as long as they specify different groupIds
There was a problem hiding this comment.
Got it, I'll update it.
kowalczyk-krzysztof
changed the title
5 participants
Summary
This PR:
sepErator->sepArator,top-navprefixed test subjects in app menu toapp-menuprefix,popoverTestIdproperty,anchorElement) popoverCloses: https://github.com/elastic/kibana-team/issues/2618