refactor(write restricted dashboards): Assign clear error messages for access control errors #248062
+45
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
reviewed
Jan 8, 2026
...ck/platform/plugins/shared/security/server/saved_objects/saved_objects_security_extension.ts
Outdated
Show resolved
Hide resolved
...ck/platform/plugins/shared/security/server/saved_objects/saved_objects_security_extension.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
SiddharthMantri
added
Team:Security
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
jeramysoucy
reviewed
Jan 9, 2026
Contributor
jeramysoucy
left a comment
jeramysoucy
left a comment
There was a problem hiding this comment.
LGTM, just one consideration for enforceAccessControl which can deny based on RBAC.
Comment on lines
+127
to
+129
| new Error( | ||
| `Access denied: Unable to manage access control for ${typeList}. The "manage_access_control" privilege is required to change access control of objects owned by another user.` | ||
| ) |
Contributor
There was a problem hiding this comment.
What if they are denied access because they now lack RBAC privs?
Comment on lines
+168
to
+170
| new Error( | ||
| `Access denied: Unable to manage access control for ${typeList}. The "manage_access_control" privilege is required to change access control of objects owned by another user.` | ||
| ) |
Contributor
There was a problem hiding this comment.
Same as above, what if they are denied access because they now lack RBAC privs?
Contributor
|
@SiddharthMantri Could you update the PR description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237817
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.