[Flaky test] Observability alerts pagination - Previous page button is disabled #248044
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the button state
cesco-f
added
release_note:skip
github-actions
bot
added
the
author:actionable-obs
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10317[✅] x-pack/solutions/observability/test/observability_functional/with_rac_write.config.ts: 200/200 tests passed. |
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2026
…s disabled (elastic#248044) It closes elastic#233241. ### Summary Fixes intermittent test failure in `pagination.ts` where the test `'Previous page button is disabled'` would sometimes fail with: `Error: expected null to equal 'true' ` ### Problem The test was checking the `disabled` attribute of the previous page button without waiting for the alert data to finish loading. ### Solution - Added `alertDataHasLoaded()` to wait for the alerts table to finish loading before checking the button state - Wrapped the assertion in `retry.try()` to handle any remaining timing edge cases (cherry picked from commit 8881709)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2026
…s disabled (elastic#248044) It closes elastic#233241. ### Summary Fixes intermittent test failure in `pagination.ts` where the test `'Previous page button is disabled'` would sometimes fail with: `Error: expected null to equal 'true' ` ### Problem The test was checking the `disabled` attribute of the previous page button without waiting for the alert data to finish loading. ### Solution - Added `alertDataHasLoaded()` to wait for the alerts table to finish loading before checking the button state - Wrapped the assertion in `retry.try()` to handle any remaining timing edge cases (cherry picked from commit 8881709)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2026
…s disabled (elastic#248044) It closes elastic#233241. ### Summary Fixes intermittent test failure in `pagination.ts` where the test `'Previous page button is disabled'` would sometimes fail with: `Error: expected null to equal 'true' ` ### Problem The test was checking the `disabled` attribute of the previous page button without waiting for the alert data to finish loading. ### Solution - Added `alertDataHasLoaded()` to wait for the alerts table to finish loading before checking the button state - Wrapped the assertion in `retry.try()` to handle any remaining timing edge cases (cherry picked from commit 8881709)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2026
…utton is disabled (#248044) (#248222) # Backport This will backport the following commits from `main` to `8.19`: - [[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)](#248044) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2026-01-08T09:41:01Z","message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.4.0","author:actionable-obs","v9.2.4","v9.1.10","v8.19.10"],"title":"[Flaky test] Observability alerts pagination - Previous page button is disabled","number":248044,"url":"https://github.com/elastic/kibana/pull/248044","mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248044","number":248044,"mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},{"branch":"9.2","label":"v9.2.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2026
…tton is disabled (#248044) (#248224) # Backport This will backport the following commits from `main` to `9.2`: - [[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)](#248044) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2026-01-08T09:41:01Z","message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.4.0","author:actionable-obs","v9.2.4","v9.1.10","v8.19.10"],"title":"[Flaky test] Observability alerts pagination - Previous page button is disabled","number":248044,"url":"https://github.com/elastic/kibana/pull/248044","mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248044","number":248044,"mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},{"branch":"9.2","label":"v9.2.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2026
…tton is disabled (#248044) (#248223) # Backport This will backport the following commits from `main` to `9.1`: - [[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)](#248044) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2026-01-08T09:41:01Z","message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","backport:version","v9.4.0","author:actionable-obs","v9.2.4","v9.1.10","v8.19.10"],"title":"[Flaky test] Observability alerts pagination - Previous page button is disabled","number":248044,"url":"https://github.com/elastic/kibana/pull/248044","mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248044","number":248044,"mergeCommit":{"message":"[Flaky test] Observability alerts pagination - Previous page button is disabled (#248044)\n\nIt closes https://github.com/elastic/kibana/issues/233241.\n\n### Summary\n\nFixes intermittent test failure in `pagination.ts` where the test\n`'Previous page button is disabled'` would sometimes fail with:\n\n`Error: expected null to equal 'true'\n`\n### Problem\n\nThe test was checking the `disabled` attribute of the previous page\nbutton without waiting for the alert data to finish loading.\n\n### Solution\n\n- Added `alertDataHasLoaded()` to wait for the alerts table to finish\nloading before checking the button state\n- Wrapped the assertion in `retry.try()` to handle any remaining timing\nedge cases","sha":"8881709d182d0a632713194fab8f40c646565339"}},{"branch":"9.2","label":"v9.2.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #233241.
Summary
Fixes intermittent test failure in
pagination.tswhere the test'Previous page button is disabled'would sometimes fail with:Error: expected null to equal 'true'Problem
The test was checking the
disabledattribute of the previous page button without waiting for the alert data to finish loading.Solution
alertDataHasLoaded()to wait for the alerts table to finish loading before checking the button stateretry.try()to handle any remaining timing edge cases