[9.3] [AI Infra] Fix Security Labs install not working (#248032) #248039
+119
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Resolves elastic#247549 Security Labs (`installSecurityLabs`) would download to `artifactPath` but then open the zip using `artifactPath`, not the returned safe path. That worked "by accident" as long as the downloader wrote to exactly that path; once `downloadToDisk()` started writing to a safe location under `data/`, the Security Labs install started failing. #### Root cause `downloadToDisk()` was updated to use `@kbn/fs safe-path` handling (dce7e81). That change makes writes land under Kibana’s `data/` dir (like `.../data/ai-kb-artifacts/...`), which is safer — but it exposed the bug where Security Labs didn’t use the returned full path. #### Fix details Security Labs now opens the zip using the downloadToDisk() return value (the same pattern the main product docs path already used), so it opens the file where it was actually written, and corresponding tests to catch this have been added. ### Checklist - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 599427f)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
Historycc @spong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation