Skip to content

[Security Assistant] EIS usage callout #221566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Jun 16, 2025
Merged

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 26, 2025

Summary

https://github.com/elastic/security-team/issues/12656
https://github.com/elastic/kibana/pull/220782/files#

To test:

  1. https://p.elstc.co/paste/w06HF7Yw#2tr6JjZXmUbjQ6TQdpgdenH4YOjiWdAoHCZ3OpRi5JG
  2. locally:
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js

Callouts will not appear again once dismissed. Please clear the local storage if you want them to show up again.

Screenshot 2025-05-29 at 15 53 21

onboarding hub:
Screenshot 2025-05-29 at 09 32 14

Assistant:
Screenshot 2025-06-11 at 15 16 09

Conversation:
452997822-5c0b3933-b253-474e-92a5-d8793ebff819

Integration:
Screenshot 2025-05-28 at 21 28 11

Attack Discovery:
Screenshot 2025-06-11 at 15 35 08

feature_flags.overrides:
  securitySolution.attackDiscoveryAlertsEnabled: true
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
Screenshot 2025-06-11 at 15 30 53

Connectors:
Screenshot 2025-06-10 at 11 15 41

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@angorayc angorayc added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project labels May 26, 2025
@angorayc angorayc changed the title add EIS cost callout EIS usage callout May 27, 2025
@angorayc angorayc added v9.1.0 v8.19.0 Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels labels May 28, 2025
@angorayc angorayc marked this pull request as ready for review May 29, 2025 14:57
@angorayc angorayc requested review from a team as code owners May 29, 2025 14:57
@angorayc angorayc changed the title EIS usage callout [GenAI] EIS usage callout May 29, 2025
@angorayc angorayc changed the title [GenAI] EIS usage callout [Security GenAI] EIS usage callout May 29, 2025
@kibanamachine
Copy link
Contributor

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/212

@kibanamachine
Copy link
Contributor

Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/462

@angorayc angorayc requested a review from a team as a code owner May 30, 2025 15:45
@angorayc angorayc requested a review from darnautov June 13, 2025 10:48
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threat hunting code LGTM

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core changes LGMT (removal of esUiShared requiredBundle in kibana.jsonc file)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM [ Automatic Import changes ]

@angorayc angorayc enabled auto-merge (squash) June 16, 2025 09:22
@angorayc angorayc requested a review from a team June 16, 2025 11:38
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 16, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
automaticImport 781 753 -28
securitySolution 7602 7610 +8
stackConnectors 320 321 +1
total -19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 76.9KB 77.0KB +145.0B
automaticImport 1.1MB 1.1MB -2.0KB
lists 123.6KB 123.7KB +145.0B
securitySolution 9.3MB 9.3MB +11.3KB
stackConnectors 623.2KB 624.5KB +1.3KB
total +10.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
automaticImport 11.6KB 11.2KB -470.0B
core 456.7KB 456.8KB +145.0B
securitySolution 93.2KB 93.2KB +1.0B
stackConnectors 60.5KB 60.8KB +231.0B
total -93.0B
Unknown metric groups

async chunk count

id before after diff
stackConnectors 101 102 +1

ESLint disabled line counts

id before after diff
stackConnectors 133 134 +1

miscellaneous assets size

id before after diff
automaticImport 891.4KB 250.8KB -640.6KB

Total ESLint disabled count

id before after diff
stackConnectors 137 138 +1

History

@angorayc angorayc merged commit ed9f4e9 into elastic:main Jun 16, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/15682351634

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 221566

Questions ?

Please refer to the Backport tool documentation

angorayc added a commit to angorayc/kibana that referenced this pull request Jun 16, 2025
elastic/security-team#12656
https://github.com/elastic/kibana/pull/220782/files#

To test:
1.
https://p.elstc.co/paste/w06HF7Yw#2tr6JjZXmUbjQ6TQdpgdenH4YOjiWdAoHCZ3OpRi5JG
2. locally:

```
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js
```

Callouts will not appear again once dismissed. Please clear the local
storage if you want them to show up again.

<img width="2557" alt="Screenshot 2025-05-29 at 15 53 21"
src="https://github.com/user-attachments/assets/506925cb-5bce-4a66-918e-cd9e000c7088"
/>

onboarding hub:
<img width="2559" alt="Screenshot 2025-05-29 at 09 32 14"
src="https://github.com/user-attachments/assets/4c8b99e5-156e-4062-95a9-fa45c101b858"
/>

Assistant:
<img width="1282" alt="Screenshot 2025-06-11 at 15 16 09"
src="https://github.com/user-attachments/assets/30d47a05-ded1-4c3e-9540-6ad97fda0a8b"
/>

Conversation:
<img width="674" alt="452997822-5c0b3933-b253-474e-92a5-d8793ebff819"
src="https://github.com/user-attachments/assets/97506996-9a85-45bb-a728-79df37bd592e"
/>

Integration:
<img width="2559" alt="Screenshot 2025-05-28 at 21 28 11"
src="https://github.com/user-attachments/assets/ec564dac-2aed-4ac5-ad2c-67728d6f3eda"
/>

Attack Discovery:
<img width="2560" alt="Screenshot 2025-06-11 at 15 35 08"
src="https://github.com/user-attachments/assets/9816fc43-0e6e-40b2-862b-82673330c4da"
/>

```
feature_flags.overrides:
  securitySolution.attackDiscoveryAlertsEnabled: true
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```
<img width="2560" alt="Screenshot 2025-06-11 at 15 30 53"
src="https://github.com/user-attachments/assets/7089626f-a416-4260-92f0-1be3f06cf5d3"
/>

Connectors:
<img width="2559" alt="Screenshot 2025-06-10 at 11 15 41"
src="https://github.com/user-attachments/assets/74773473-ff1c-41c1-bdd5-fe6e64b9a497"
/>

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
(cherry picked from commit ed9f4e9)
angorayc added a commit to angorayc/kibana that referenced this pull request Jun 16, 2025
elastic/security-team#12656
https://github.com/elastic/kibana/pull/220782/files#

To test:
1.
https://p.elstc.co/paste/w06HF7Yw#2tr6JjZXmUbjQ6TQdpgdenH4YOjiWdAoHCZ3OpRi5JG
2. locally:

```
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js
```

Callouts will not appear again once dismissed. Please clear the local
storage if you want them to show up again.

<img width="2557" alt="Screenshot 2025-05-29 at 15 53 21"
src="https://github.com/user-attachments/assets/506925cb-5bce-4a66-918e-cd9e000c7088"
/>

onboarding hub:
<img width="2559" alt="Screenshot 2025-05-29 at 09 32 14"
src="https://github.com/user-attachments/assets/4c8b99e5-156e-4062-95a9-fa45c101b858"
/>

Assistant:
<img width="1282" alt="Screenshot 2025-06-11 at 15 16 09"
src="https://github.com/user-attachments/assets/30d47a05-ded1-4c3e-9540-6ad97fda0a8b"
/>

Conversation:
<img width="674" alt="452997822-5c0b3933-b253-474e-92a5-d8793ebff819"
src="https://github.com/user-attachments/assets/97506996-9a85-45bb-a728-79df37bd592e"
/>

Integration:
<img width="2559" alt="Screenshot 2025-05-28 at 21 28 11"
src="https://github.com/user-attachments/assets/ec564dac-2aed-4ac5-ad2c-67728d6f3eda"
/>

Attack Discovery:
<img width="2560" alt="Screenshot 2025-06-11 at 15 35 08"
src="https://github.com/user-attachments/assets/9816fc43-0e6e-40b2-862b-82673330c4da"
/>

```
feature_flags.overrides:
  securitySolution.attackDiscoveryAlertsEnabled: true
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```
<img width="2560" alt="Screenshot 2025-06-11 at 15 30 53"
src="https://github.com/user-attachments/assets/7089626f-a416-4260-92f0-1be3f06cf5d3"
/>

Connectors:
<img width="2559" alt="Screenshot 2025-06-10 at 11 15 41"
src="https://github.com/user-attachments/assets/74773473-ff1c-41c1-bdd5-fe6e64b9a497"
/>

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
(cherry picked from commit ed9f4e9)
angorayc added a commit to angorayc/kibana that referenced this pull request Jun 16, 2025
elastic/security-team#12656
https://github.com/elastic/kibana/pull/220782/files#

To test:
1.
https://p.elstc.co/paste/w06HF7Yw#2tr6JjZXmUbjQ6TQdpgdenH4YOjiWdAoHCZ3OpRi5JG
2. locally:

```
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js
```

Callouts will not appear again once dismissed. Please clear the local
storage if you want them to show up again.

<img width="2557" alt="Screenshot 2025-05-29 at 15 53 21"
src="https://github.com/user-attachments/assets/506925cb-5bce-4a66-918e-cd9e000c7088"
/>

onboarding hub:
<img width="2559" alt="Screenshot 2025-05-29 at 09 32 14"
src="https://github.com/user-attachments/assets/4c8b99e5-156e-4062-95a9-fa45c101b858"
/>

Assistant:
<img width="1282" alt="Screenshot 2025-06-11 at 15 16 09"
src="https://github.com/user-attachments/assets/30d47a05-ded1-4c3e-9540-6ad97fda0a8b"
/>

Conversation:
<img width="674" alt="452997822-5c0b3933-b253-474e-92a5-d8793ebff819"
src="https://github.com/user-attachments/assets/97506996-9a85-45bb-a728-79df37bd592e"
/>

Integration:
<img width="2559" alt="Screenshot 2025-05-28 at 21 28 11"
src="https://github.com/user-attachments/assets/ec564dac-2aed-4ac5-ad2c-67728d6f3eda"
/>

Attack Discovery:
<img width="2560" alt="Screenshot 2025-06-11 at 15 35 08"
src="https://github.com/user-attachments/assets/9816fc43-0e6e-40b2-862b-82673330c4da"
/>

```
feature_flags.overrides:
  securitySolution.attackDiscoveryAlertsEnabled: true
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```
<img width="2560" alt="Screenshot 2025-06-11 at 15 30 53"
src="https://github.com/user-attachments/assets/7089626f-a416-4260-92f0-1be3f06cf5d3"
/>

Connectors:
<img width="2559" alt="Screenshot 2025-06-10 at 11 15 41"
src="https://github.com/user-attachments/assets/74773473-ff1c-41c1-bdd5-fe6e64b9a497"
/>

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
(cherry picked from commit ed9f4e9)
angorayc added a commit that referenced this pull request Jun 17, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Security Assistant] EIS usage callout
#221566(#221566)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
szwarckonrad added a commit that referenced this pull request Jun 17, 2025
Tracks #221566
Closes elastic/security-team#12824

With this change, whenever a user selects the Elastic LLM connector
within the Automatic Troubleshooting feature, they'll see a callout
informing them about the potential costs of using it. Once the callout
is acknowledged, it will be dismissed and the closed state will be
stored in local storage, so it won’t appear again on future visits.

To enable EIS locally:
```
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js
```
and run ES server with provided env + start kibana with .dev.yaml entry
from the output of the command above.


https://github.com/user-attachments/assets/51a2ce77-ed25-4611-9d62-72e9d09bb789

---------

Co-authored-by: Angela Chuang <[email protected]>
Co-authored-by: Angela Chuang <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
angorayc added a commit that referenced this pull request Jun 17, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Security Assistant] EIS usage callout
#221566(#221566)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
angorayc added a commit that referenced this pull request Jun 17, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Security Assistant] EIS usage callout
#221566(#221566)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
szwarckonrad added a commit to szwarckonrad/kibana that referenced this pull request Jun 17, 2025
Tracks elastic#221566
Closes elastic/security-team#12824

With this change, whenever a user selects the Elastic LLM connector
within the Automatic Troubleshooting feature, they'll see a callout
informing them about the potential costs of using it. Once the callout
is acknowledged, it will be dismissed and the closed state will be
stored in local storage, so it won’t appear again on future visits.

To enable EIS locally:
```
export VAULT_ADDR=https://secrets.elastic.co:8200/
vault login --method=oidc
node scripts/eis.js
```
and run ES server with provided env + start kibana with .dev.yaml entry
from the output of the command above.

https://github.com/user-attachments/assets/51a2ce77-ed25-4611-9d62-72e9d09bb789

---------

Co-authored-by: Angela Chuang <[email protected]>
Co-authored-by: Angela Chuang <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: Viduni Wickramarachchi <[email protected]>
(cherry picked from commit dfe6f54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project release_note:enhancement Team:Security Generative AI Security Generative AI v8.18.3 v8.19.0 v9.0.3 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.