Skip to content

[Search][Query Rules UI] Test in console and delete ruleset from details page #221350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented May 23, 2025

Summary

Adding Test in Console and Delete from the Ruleset details page:

CleanShot.2025-05-23.at.12.20.12.mp4

Test in Console example populating data from the ruleset selected:

CleanShot 2025-05-23 at 12 18 35@2x

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@JoseLuisGJ JoseLuisGJ changed the title Test-ruleset-detailspage [Search][Query Rules UI] Test in console and delete ruleset from details page May 23, 2025
@JoseLuisGJ JoseLuisGJ self-assigned this May 23, 2025
@JoseLuisGJ JoseLuisGJ added release_note:skip Skip the PR/issue when compiling release notes Team:Search backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 23, 2025
@JoseLuisGJ JoseLuisGJ marked this pull request as ready for review May 23, 2025 10:25
@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner May 23, 2025 10:25
@elasticmachine
Copy link
Contributor

elasticmachine commented May 23, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / Query rule detail existing query ruleset should render the query ruleset detail page
  • [job] [logs] Jest Tests #6 / Query rule detail existing query ruleset should render the query ruleset detail page
  • [job] [logs] Jest Tests #6 / UseRunQueryRuleset creates correct query with ruleset ID in the request
  • [job] [logs] Jest Tests #6 / UseRunQueryRuleset creates correct query with ruleset ID in the request

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchQueryRules 45.5KB 46.9KB +1.4KB

History

cc @JoseLuisGJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants