Skip to content

Revert "Remove FF for gaps" #221347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Revert "Remove FF for gaps" #221347

merged 1 commit into from
May 23, 2025

Conversation

nkhristinin
Copy link
Contributor

Reverts #219737

As we found 2 high impact bugs, we want to fix it before it will be Gaps will be available on serverless

@nkhristinin nkhristinin marked this pull request as ready for review May 23, 2025 10:51
@nkhristinin nkhristinin requested review from a team as code owners May 23, 2025 10:51
@nkhristinin nkhristinin requested review from rylnd and jkelas May 23, 2025 10:51
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 23, 2025
jkelas
jkelas approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@jkelas jkelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually verified that the PR correctly restores the previous PR #219737. Approving.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.2MB 9.2MB +120.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.3KB 88.3KB +30.0B

@nkhristinin nkhristinin enabled auto-merge (squash) May 23, 2025 15:52
rylnd
rylnd approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkhristinin nkhristinin merged commit dcac7aa into main May 23, 2025
16 checks passed
@nkhristinin nkhristinin deleted the revert-219737-remove-gaps-ff branch May 23, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@jkelas jkelas jkelas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkhristinin @elasticmachine @rylnd @jkelas @kibanamachine