Skip to content

[EDR Workflows] Change Automatic Troubleshooting empty results copy #221343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented May 23, 2025

Awaiting decision on backport depth

Change the copy from No issues had been found to Troubleshooting scan complete, no issues found. on empty results.

@szwarckonrad szwarckonrad requested a review from joeypoon May 23, 2025 08:55
@szwarckonrad szwarckonrad self-assigned this May 23, 2025
@szwarckonrad szwarckonrad requested a review from a team as a code owner May 23, 2025 08:55
@szwarckonrad szwarckonrad requested a review from paul-tavares May 23, 2025 08:55
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.1.0 labels May 23, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@szwarckonrad szwarckonrad added the backport:skip This commit does not require backporting label May 23, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.2MB 9.2MB +23.0B

History

cc @szwarckonrad

@szwarckonrad szwarckonrad added v9.0.0 backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting labels May 28, 2025
@szwarckonrad szwarckonrad merged commit 8dfb069 into elastic:main May 28, 2025
15 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/15296427567

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2025
…lastic#221343)

**Awaiting decision on backport depth**

Change the copy from `No issues had been found` to `Troubleshooting scan
complete, no issues found.` on empty results.

(cherry picked from commit 8dfb069)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 28, 2025
…copy (#221343) (#221749)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[EDR Workflows] Change Automatic Troubleshooting empty results copy
(#221343)](#221343)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-28T09:20:22Z","message":"[EDR
Workflows] Change Automatic Troubleshooting empty results copy
(#221343)\n\n**Awaiting decision on backport depth**\n\nChange the copy
from `No issues had been found` to `Troubleshooting scan\ncomplete, no
issues found.` on empty
results.","sha":"8dfb069cd66ffb29ed844098637edf4510e636d6","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","backport:version","v9.1.0"],"title":"[EDR Workflows] Change
Automatic Troubleshooting empty results
copy","number":221343,"url":"https://github.com/elastic/kibana/pull/221343","mergeCommit":{"message":"[EDR
Workflows] Change Automatic Troubleshooting empty results copy
(#221343)\n\n**Awaiting decision on backport depth**\n\nChange the copy
from `No issues had been found` to `Troubleshooting scan\ncomplete, no
issues found.` on empty
results.","sha":"8dfb069cd66ffb29ed844098637edf4510e636d6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221343","number":221343,"mergeCommit":{"message":"[EDR
Workflows] Change Automatic Troubleshooting empty results copy
(#221343)\n\n**Awaiting decision on backport depth**\n\nChange the copy
from `No issues had been found` to `Troubleshooting scan\ncomplete, no
issues found.` on empty
results.","sha":"8dfb069cd66ffb29ed844098637edf4510e636d6"}}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <[email protected]>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…lastic#221343)

**Awaiting decision on backport depth**

Change the copy from `No issues had been found` to `Troubleshooting scan
complete, no issues found.` on empty results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.0.0 v9.0.2 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants