Skip to content

[Workchat] Hide disabled integrations when creating a new tool #221306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zacharyparikh
Copy link
Contributor

@zacharyparikh zacharyparikh commented May 22, 2025

Summary

Screenshot 2025-05-22 at 1 33 11 PM

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@zacharyparikh zacharyparikh requested review from a team as code owners May 22, 2025 18:42
@zacharyparikh zacharyparikh added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels May 22, 2025
Copy link
Contributor

@meghanmurphy1 meghanmurphy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 LGTM! also you can just use the releasenote:skip label for this 🙂

@meghanmurphy1 meghanmurphy1 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels May 22, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #93 / Entity Analytics - Risk Engine @ess @serverless @serverlessQA Risk Scoring Task Execution with auditbeat data with some alerts containing hosts initializing the risk engine @skipInServerlessMKI starts the latest transform
  • [job] [logs] FTR Configs #79 / Synthetics API Tests SyncGlobalParams parsed params for previously added http monitors

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
workchatApp 120.0KB 120.3KB +295.0B

@zacharyparikh zacharyparikh merged commit 58e61a0 into elastic:main May 23, 2025
22 checks passed
@zacharyparikh zacharyparikh deleted the create-tool/hide-disabled-integrations branch May 23, 2025 13:33
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…ic#221306)

## Summary

![Screenshot 2025-05-22 at 1 33
11 PM](https://github.com/user-attachments/assets/f6e4c373-353c-4faa-b13a-004668fb2218)


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants