Skip to content

[Search] Playground sends telemetry headers with completion requests #221292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented May 22, 2025

Summary

Playground now sends the X-Elastic-Product-Use-Case header with a search_playground for telemetry purposes.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@sphilipse sphilipse requested a review from a team as a code owner May 22, 2025 16:54
@sphilipse sphilipse added the release_note:skip Skip the PR/issue when compiling release notes label May 22, 2025
@sphilipse sphilipse requested a review from a team as a code owner May 22, 2025 16:54
@sphilipse sphilipse added Team:Search backport:version Backport to applied version labels v9.1.0 labels May 22, 2025
@sphilipse sphilipse enabled auto-merge (squash) May 23, 2025 13:28
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/inference-langchain 48 49 +1
Unknown metric groups

API count

id before after diff
@kbn/inference-langchain 49 50 +1

History

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sphilipse sphilipse merged commit dc5f2ec into elastic:main May 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants