Skip to content

[AI4DSOC] [REVERT] Disable Visualize, Lens and Maps for Search AI Lake Tier #218089 #221141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented May 21, 2025

Reverts: #218089

Previous PR:
Screenshot 2025-05-21 at 17 52 10

This PR:
Screenshot 2025-05-21 at 18 04 15


We realized that there are so many dependencies on lens, and thus visualizations that we decided to revert this, and find another way to hide the features in AI_SOC plugin. Hopefully approach with overrides would be just enough for our need.

Thank you everyone for the initial help and reviews.

@tomsonpl tomsonpl self-assigned this May 21, 2025
@tomsonpl tomsonpl changed the title revert lens, visualizations, maps changes [AI4DSOC] [REVERT] Disable Visualize, Lens and Maps for Search AI Lake Tier #218089 May 21, 2025
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Security Generative AI Security Generative AI v9.1.0 labels May 21, 2025
@tomsonpl
Copy link
Contributor Author

@nreese @azasypkin @TattdCodeMonkey @davismcphee @jbudz @jloleysens @ppisljar @PhilippeOberti @vgomez-el

Hey all!
Since you reviewed the previous one, I am letting you know that we decided to revert it. We'll try to follow a different approach to hide these features in AI_SOC :)
Sorry for the inconvenience, and big thanks again for your time 👍

@tomsonpl tomsonpl marked this pull request as ready for review May 21, 2025 16:12
@tomsonpl tomsonpl requested review from a team as code owners May 21, 2025 16:12
@tomsonpl tomsonpl requested a review from dhurley14 May 21, 2025 16:12
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels May 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB -68.0B
lens 1.6MB 1.6MB -379.0B
maps 3.0MB 3.0MB -234.0B
visualizations 335.5KB 335.4KB -34.0B
total -715.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 133.9KB 133.8KB -47.0B
maps 40.7KB 40.6KB -84.0B
total -131.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 67 68 +1

Total ESLint disabled count

id before after diff
cases 85 86 +1

cc @tomsonpl

@jbudz
Copy link
Member

jbudz commented May 21, 2025

Merging now, it's a 1 for 1 revert.

@jbudz jbudz merged commit 4cfcf3b into elastic:main May 21, 2025
14 checks passed
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…e Tier elastic#218089 (elastic#221141)

Reverts: elastic#218089 

Previous PR: 
<img width="199" alt="Screenshot 2025-05-21 at 17 52 10"
src="https://github.com/user-attachments/assets/51e87073-eec5-47fc-8c20-59399a9e1042"
/>

This PR:
<img width="215" alt="Screenshot 2025-05-21 at 18 04 15"
src="https://github.com/user-attachments/assets/30e5bc50-b9e4-486f-af17-e42ca5c6b84c"
/>


-----

We realized that there are so many dependencies on `lens`, and thus
`visualizations` that we decided to revert this, and find another way to
hide the features in AI_SOC plugin. Hopefully approach with `overrides`
would be just enough for our need.

Thank you everyone for the initial help and reviews.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team Team:Security Generative AI Security Generative AI v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants