-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[CLOUD] fix defaultRoute for app/cloud/onboarding #221029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
eokoneyo
approved these changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
TinaHeiligers
approved these changes
May 21, 2025
Starting backport for target branches: 8.18, 8.19, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 21, 2025
## Summary The uiSettings client need to have the Kibana request to send back the defaultRoute for a space. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6f41f41)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 21, 2025
## Summary The uiSettings client need to have the Kibana request to send back the defaultRoute for a space. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6f41f41)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 21, 2025
## Summary The uiSettings client need to have the Kibana request to send back the defaultRoute for a space. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 6f41f41)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 21, 2025
…21175) # Backport This will backport the following commits from `main` to `9.0`: - [[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)](#221029) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-21T18:32:00Z","message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Cloud","release_note:skip","backport:version","v9.1.0","v8.19.0","v8.18.2","v9.0.2"],"title":"[CLOUD] fix defaultRoute for app/cloud/onboarding","number":221029,"url":"https://github.com/elastic/kibana/pull/221029","mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221029","number":221029,"mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
May 21, 2025
…221174) # Backport This will backport the following commits from `main` to `8.19`: - [[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)](#221029) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-21T18:32:00Z","message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Cloud","release_note:skip","backport:version","v9.1.0","v8.19.0","v8.18.2","v9.0.2"],"title":"[CLOUD] fix defaultRoute for app/cloud/onboarding","number":221029,"url":"https://github.com/elastic/kibana/pull/221029","mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221029","number":221029,"mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
May 21, 2025
…221173) # Backport This will backport the following commits from `main` to `8.18`: - [[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)](#221029) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-21T18:32:00Z","message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Cloud","release_note:skip","backport:version","v9.1.0","v8.19.0","v8.18.2","v9.0.2"],"title":"[CLOUD] fix defaultRoute for app/cloud/onboarding","number":221029,"url":"https://github.com/elastic/kibana/pull/221029","mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221029","number":221029,"mergeCommit":{"message":"[CLOUD] fix defaultRoute for app/cloud/onboarding (#221029)\n\n## Summary\n\nThe uiSettings client need to have the Kibana request to send back the\ndefaultRoute for a space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"6f41f416262e5368d12c5f8deab64fe28af9a890"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Cloud
v8.18.2
v8.19.0
v9.0.2
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The uiSettings client need to have the Kibana request to send back the defaultRoute for a space.
Checklist