[Controls] Bulk select for options list control #221010
Open
+246
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
controls/options-list/select-deselect-all
branch
from
d036377 to
812c7ee
Compare
|
Cloud deployments require a Github label, please add |
Fix select and deselect logic Fix types Fetch more options on select/deselect all Add loadMoreOptions callback Add const for bulk selection limit Add i18n Remove unused import
cqliu1
force-pushed
the
controls/options-list/select-deselect-all
branch
from
d0646ff to
263c283
Compare
cqliu1
changed the title
cqliu1
changed the title
cqliu1
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
cqliu1
added
release_note:feature
💔 Build Failed
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #181694.
This adds
Select allandDeselect allbuttons to the options list popover to allow users to make bulk selections. Bulk selections will only be available when there are 100 or fewer available options.Disabled bulk select
Bulk selection is disabled when there are no available options.
Bulk selection is also disabled when total cardinality is over 100.
When
showOnlySelectedis enabledEven if the total cardinality is greater than the bulk selection limit, bulk selection is enabled when
showOnlySelectedis enabled, and the number of selection options is fewer than the bulk selection limit (e.g. fewer than 100 selections).Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.