Skip to content

[Attack Discovery][Scheduling] Telemetry (#12008) #220998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented May 20, 2025

Summary

Main ticket (Internal link)

These changes add attack discovery schedules telemetry similarly to existing manually generated attack discoveries added in this commit 3c41972.

NOTES

The feature is hidden behind the feature flag (in kibana.dev.yml):

feature_flags.overrides:
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true

@e40pud e40pud requested a review from andrew-goldstein May 20, 2025 13:42
@e40pud e40pud self-assigned this May 20, 2025
@e40pud e40pud requested a review from a team as a code owner May 20, 2025 13:42
@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e40pud for the additional telemetry, and for paring on the review!

e40pud added 3 commits May 20, 2025 20:37
# Conflicts:
#	x-pack/solutions/security/plugins/elastic_assistant/server/lib/attack_discovery/schedules/register_schedule/executor.ts
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @e40pud

@e40pud e40pud merged commit 94113be into elastic:main May 21, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15166456900

@e40pud
Copy link
Contributor Author

e40pud commented May 21, 2025

Example of the reported event for AD schedule

Screenshot 2025-05-21 at 17 39 04

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 21, 2025
)

## Summary

Main ticket ([Internal
link](elastic/security-team#12008))

These changes add attack discovery schedules telemetry similarly to
existing manually generated attack discoveries added in this commit
elastic@3c41972.

## NOTES

The feature is hidden behind the feature flag (in `kibana.dev.yml`):

```
feature_flags.overrides:
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```

(cherry picked from commit 94113be)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 21, 2025
…221142)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Attack Discovery][Scheduling] Telemetry (#12008)
(#220998)](#220998)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-21T15:35:46Z","message":"[Attack
Discovery][Scheduling] Telemetry (#12008) (#220998)\n\n##
Summary\n\nMain ticket
([Internal\nlink](https://github.com/elastic/security-team/issues/12008))\n\nThese
changes add attack discovery schedules telemetry similarly to\nexisting
manually generated attack discoveries added in this
commit\nhttps://github.com//pull/184949/commits/3c419729337cf3fa9f1ff5ddb49a4ed07d102324.\n\n##
NOTES\n\nThe feature is hidden behind the feature flag (in
`kibana.dev.yml`):\n\n```\nfeature_flags.overrides:\n
securitySolution.assistantAttackDiscoverySchedulingEnabled:
true\n```","sha":"94113be9f19c15412beee25fbac627fa07bf7d1a","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v9.1.0","v8.19.0"],"title":"[Attack
Discovery][Scheduling] Telemetry
(#12008)","number":220998,"url":"https://github.com/elastic/kibana/pull/220998","mergeCommit":{"message":"[Attack
Discovery][Scheduling] Telemetry (#12008) (#220998)\n\n##
Summary\n\nMain ticket
([Internal\nlink](https://github.com/elastic/security-team/issues/12008))\n\nThese
changes add attack discovery schedules telemetry similarly to\nexisting
manually generated attack discoveries added in this
commit\nhttps://github.com//pull/184949/commits/3c419729337cf3fa9f1ff5ddb49a4ed07d102324.\n\n##
NOTES\n\nThe feature is hidden behind the feature flag (in
`kibana.dev.yml`):\n\n```\nfeature_flags.overrides:\n
securitySolution.assistantAttackDiscoverySchedulingEnabled:
true\n```","sha":"94113be9f19c15412beee25fbac627fa07bf7d1a"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220998","number":220998,"mergeCommit":{"message":"[Attack
Discovery][Scheduling] Telemetry (#12008) (#220998)\n\n##
Summary\n\nMain ticket
([Internal\nlink](https://github.com/elastic/security-team/issues/12008))\n\nThese
changes add attack discovery schedules telemetry similarly to\nexisting
manually generated attack discoveries added in this
commit\nhttps://github.com//pull/184949/commits/3c419729337cf3fa9f1ff5ddb49a4ed07d102324.\n\n##
NOTES\n\nThe feature is hidden behind the feature flag (in
`kibana.dev.yml`):\n\n```\nfeature_flags.overrides:\n
securitySolution.assistantAttackDiscoverySchedulingEnabled:
true\n```","sha":"94113be9f19c15412beee25fbac627fa07bf7d1a"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
)

## Summary

Main ticket ([Internal
link](elastic/security-team#12008))

These changes add attack discovery schedules telemetry similarly to
existing manually generated attack discoveries added in this commit
elastic@3c41972.

## NOTES

The feature is hidden behind the feature flag (in `kibana.dev.yml`):

```
feature_flags.overrides:
  securitySolution.assistantAttackDiscoverySchedulingEnabled: true
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants