Skip to content

Fix intermittent failure of DirectIOIT #128463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Fix intermittent failure of DirectIOIT #128463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5043e19
Fix intermittent failure of DirectIOIT
ChrisHegarty May 26, 2025
5d27f69
Merge branch 'lucene_snapshot' into dio_test_fix
ChrisHegarty May 27, 2025
1f213e6
Merge branch 'lucene_snapshot' into dio_test_fix
ChrisHegarty May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 30 additions & 23 deletions server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
import java.util.List;
import java.util.stream.IntStream;

import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked;
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount;

@LuceneTestCase.SuppressCodecs("*") // only use our own codecs
public class DirectIOIT extends ESIntegTestCase {

Expand All @@ -33,30 +36,31 @@ protected Collection<Class<? extends Plugin>> nodePlugins() {
}

private void indexVectors() {
internalCluster().startNode();
prepareCreate("vectors").setSettings(Settings.builder().put(InternalSettingsPlugin.USE_COMPOUND_FILE.getKey(), false))
.setMapping("""
{
"properties": {
"vector": {
"type": "dense_vector",
"dims": 64,
"element_type": "float",
"index": true,
"similarity": "l2_norm",
"index_options": {
"type": "bbq_flat"
assertAcked(
prepareCreate("foo-vectors").setSettings(Settings.builder().put(InternalSettingsPlugin.USE_COMPOUND_FILE.getKey(), false))
.setMapping("""
{
"properties": {
"fooVector": {
"type": "dense_vector",
"dims": 64,
"element_type": "float",
"index": true,
"similarity": "l2_norm",
"index_options": {
"type": "bbq_flat"
}
}
}
}
}
}
""")
.get();
ensureGreen("vectors");
""")
);
ensureGreen("foo-vectors");

for (int i = 0; i < 1000; i++) {
indexDoc("vectors", Integer.toString(i), "vector", IntStream.range(0, 64).mapToDouble(d -> randomFloat()).toArray());
indexDoc("foo-vectors", Integer.toString(i), "fooVector", IntStream.range(0, 64).mapToDouble(d -> randomFloat()).toArray());
}
refresh();
}

@TestLogging(value = "org.elasticsearch.index.store.FsDirectoryFactory:DEBUG", reason = "to capture trace logging for direct IO")
Expand All @@ -75,11 +79,14 @@ public void testDirectIOUsed() {
indexVectors();

// do a search
prepareSearch("vectors").setKnnSearch(
List.of(new KnnSearchBuilder("vector", new VectorData(null, new byte[64]), 10, 20, null, null))
).get();

var knn = List.of(new KnnSearchBuilder("fooVector", new VectorData(null, new byte[64]), 10, 20, null, null));
assertHitCount(prepareSearch("foo-vectors").setKnnSearch(knn), 10);
mockLog.assertAllExpectationsMatched();
}
}

@Override
protected boolean addMockFSIndexStore() {
return false; // we require to always use the "real" hybrid directory
}
}