Skip to content

ESQL: Enable docs for ROUND_TO #128378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 23, 2025
Merged

ESQL: Enable docs for ROUND_TO #128378

merged 5 commits into from
May 23, 2025

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 23, 2025

Plug the docs in for ROUND_TO.

@nik9000
ESQL: Enable docs for ROUND_TO
ea08218 
Plug the docs in for ROUND_TO.
@nik9000 nik9000 added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI v9.1.0 labels May 23, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)

@nik9000
Copy link
Member Author

nik9000 commented May 23, 2025 •
edited
Loading

Plugs docs in for #128278.

Marked as ES|QL-ui because it's a new function.

@nik9000 nik9000 added the >docs General docs changes label May 23, 2025
@nik9000
Copy link
Member Author

nik9000 commented May 23, 2025

It'll be in 8.19 and 9.1.0

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

leemthompo commented May 23, 2025 •
edited
Loading

👋@nik9000

I spotted a couple things looking at the live preview:

  • there seems to be a stray line from test in the example
  • ROUND_TO is not in the list of math functions at top of page

To signal that this isn't immediately available we should have an applies_to section annotation that says

<triplebackticks>
{applies_to}
stack: 9.1.0
<triplebackticks>

The docs build will then mark the feature as PLANNED so folks don't think it's live on 9.0 clusters

@leemthompo leemthompo removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 23, 2025
@nik9000
Copy link
Member Author

nik9000 commented May 23, 2025

I spotted a couple things looking at the live preview:

Got it!

leemthompo
leemthompo approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

Docs team need to cleanup the applies_to tags all over ES|QL so they're consistent and clearer but that's out of scope for this PR.

@nik9000 nik9000 enabled auto-merge (squash) May 23, 2025 16:04
@nik9000 nik9000 merged commit 584c60e into elastic:main May 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >docs General docs changes ES|QL-ui Impacts ES|QL UI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticsearchmachine @leemthompo