Skip to content

[8.19] Platform-independent paths in TestBuildInfoPluginFuncTest (#128303) #128376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented May 23, 2025

Backports the following commits to 8.19:

@prdoyle prdoyle added :Core/Infra/Entitlements Entitlements infrastructure >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team test-windows Trigger CI checks on Windows labels May 23, 2025
@prdoyle
Copy link
Contributor Author

prdoyle commented May 23, 2025

This is failing because the code is not compatible with Java 17.


Caused by: org.gradle.api.internal.tasks.compile.CompilationFailedException: Compilation failed; see the compiler output below.
--
  | /dev/shm/bk/bk-agent-prod-gcp-1748008317112679671/elastic/elasticsearch-pull-request/build-tools/src/main/java/org/elasticsearch/gradle/plugin/GenerateTestBuildInfoTask.java:222: error: cannot find symbol
  | versions = versions.reversed();
  | ^
  | symbol:   method reversed()
  | location: variable versions of type List<Integer>
  | /dev/shm/bk/bk-agent-prod-gcp-1748008317112679671/elastic/elasticsearch-pull-request/build-tools/src/main/java/org/elasticsearch/gradle/plugin/GenerateTestBuildInfoTask.java:321: error: cannot find symbol
  | File find = files.removeFirst();
  | ^
  | symbol:   method removeFirst()
  | location: variable files of type List<File>
  | 2 errors


This PR eliminates the call to List.removeFirst, so that will help a bit.

@elasticsearchmachine elasticsearchmachine merged commit 685140e into elastic:8.19 May 24, 2025
21 checks passed
@prdoyle prdoyle deleted the backport/8.19/pr-128303 branch May 24, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants