Conversation
mposik1983
requested review from
ShujieL,
bschmookler,
rahmans1,
veprbl and
wdconinc
for more information, see https://pre-commit.ci
|
|
||
| <comment> Main parameters for MPGD endcap disks, offset here is the distance between disks </comment> | ||
| <constant name="ForwardMPGD_zmin" value="1500.0*mm"/> | ||
| <constant name="ForwardMPGD_zmin" value="1285.0*mm"/> |
There was a problem hiding this comment.
This could overlap with the silicon disk, check TrackerEndcapPDisk4_zmin
There was a problem hiding this comment.
But it passed the overlap checks in CI.
There was a problem hiding this comment.
@ShujieL, I ran checkOverlaps script with tolerance set to -t 0.001 in the tracking_only configuration and the only overlaps I saw were from other sub detectors (non-mpgd) overlapping with themselves or beampipe.
There was a problem hiding this comment.
well technically there is no "overlap", but check this:
There was a problem hiding this comment.
Wow, that fit nicely in there. How should we proceed in updating the geometry to match the Sep. CAD model? Should we have this PR serve as the Tracking geometry update PR, so silicon and ToF can include their respective changes in this PR and then merge when the tracking system update is completed?
fix inner barrel mpgd rmin
adjust disk inner opening according to the beampipe shape after z position changed.
- Overlap: Module radii now derived from "rmin" of envelope. - Cosmetics: "sector" changed for "section" + documentation of XML.
github-actions
bot
added
topic: barrel
|
What is the status of this? |
|
The MPGD and SVT positions/sizes are now consistent with the September 2025 CAD envelopes in this PR. Yann's last update fixed the overlap issue within the MPGD inner barrel detector that was introduced by the change of the envelope's inner radius. So, I think we are good to merge this and update the material map. |
|
Does anyone approve the PR? |
6 participants
Briefly, what does this PR introduce?
Update MPGD envelopes to match Sept. CAD model: https://indico.bnl.gov/event/29963/
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No breaking changes. MPGD hit locations will be altered and a new material map will need to be generated.
Does this PR change default behavior?
There will be changes in the hit locations of the MPGDs, most notably the MPGD disks as they had changes made to their outer radii and were moved closer to the IP.