feat: spack: views: collapse unique subtrees in symlink case#210
Open
feat: spack: views: collapse unique subtrees in symlink case#210
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned Spack cherry-picks used by the container build pipeline to include the upstream Spack change that collapses unique subtrees for symlink views, reducing the resulting view file count.
Changes:
- Add Spack commit
d55f9abacc4e153d43a4c8bff81a383ba2f311f5toSPACK_CHERRYPICKS. - Document the new cherry-pick in the inline reference list.
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread. Indicate in |
Contributor
…211) * Initial plan * docs: clarify cherry-pick lists in spack-environment.md are illustrative Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> Agent-Logs-Url: https://github.com/eic/containers/sessions/55eaa520-04c7-42a9-ac0b-07b0bf4ff6f0 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Contributor
Author
|
This PR saves us 135k symlinks in eic_ci. |
veprbl
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR applies spack/spack#52135 to reduce the view size in terms of file count.