Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared Spack environment view configuration to reduce the number of files exposed in the default /opt/local view by linking only environment root specs, aligning with the goal of minimizing unnecessary symlinks for downstream users (e.g., OSG).
Changes:
- Configure the
defaultSpack view tolink: roots(previously implicitly linking more than roots). - Keep
link_type: symlinkand existing exclude/select behavior unchanged.
| @@ -5,6 +5,7 @@ view: | |||
| - epic | |||
| - py-pip@23.0 | |||
There was a problem hiding this comment.
exclude lists py-pip@23.0, but packages.yaml requires py-pip@23.1.2:. As a result this exclusion won’t match, so py-pip will still be linked into the view (even with link: roots). Consider excluding py-pip without a version, or using a version range that actually matches the concretized constraint.
Suggested change
| - py-pip@23.0 | |
| - py-pip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
We keep hearing about many files from OSG folks. We have a symlink for all packages, even if we don't actually need to expose some of this functionality beyond explicitly included packages. This restricts what is linked into the view to only the roots.
I think we've tried this before. I forget why it failed. We'll see...