Skip to content

eic-opticks: revert back to 073#207

Closed
veprbl wants to merge 1 commit intomasterfrom
pr/opticks_revert
Closed

eic-opticks: revert back to 073#207
veprbl wants to merge 1 commit intomasterfrom
pr/opticks_revert

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Mar 22, 2026

Original PR did break the eic_cuda container build, we need to revert.

Original PR did break the eic_cuda container build, we need to revert.
Copilot AI review requested due to automatic review settings March 22, 2026 23:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the eic-opticks Spack version pin in the shared environment configuration to restore a previously working revision after the eic_cuda container build regression.

Changes:

  • Update eic-opticks requirement from @0.1.0 back to commit @073ac31a83f9a5651b99a737b30da18117de74d5.

@veprbl
Copy link
Member Author

veprbl commented Mar 22, 2026

cc @plexoos
I think I botched the job of looking at CI to see that your fix works. Could you take a look?

@plexoos
Copy link
Member

plexoos commented Mar 23, 2026

@veprbl What error message do you see? How do you reproduce it?

@veprbl
Copy link
Member Author

veprbl commented Mar 23, 2026

@plexoos
Copy link
Member

plexoos commented Mar 23, 2026

Is there a way to reproduce this locally?

@veprbl
Copy link
Member Author

veprbl commented Mar 23, 2026

I'm not aware of any, unfortunately..

@wdconinc
Copy link
Contributor

https://github.com/eic/containers/actions/runs/23415161546/job/68109287367?pr=207#step:15:303: copy that build line, strip of the unnecessary stuff (TM), change --target builder_concretization_default to --target final (or just leave out). It should be smart enough to use the layer caches and spack build caches.

/usr/bin/docker buildx build --build-arg BENCHMARK_COM_SHA=e0fd4d1e68118780553b2698a79ba80a9970f344 --build-arg BENCHMARK_DET_SHA=89780d39009c79c4c7c700cbbf000fc217988ad9 --build-arg BENCHMARK_REC_SHA=7111579180e103f41ca2d0d6e6064f9829304674 --build-arg BENCHMARK_PHY_SHA=e6eaedc71c186ebccfc891a30a8a70003a1aa892 --build-arg CAMPAIGNS_HEPMC3_SHA=ff32b3ec30de195d42198512483dd6b2a5136fa5 --build-arg CAMPAIGNS_CONDOR_SHA=bcd39e2829ecfba8f8065037f329849fc320c501 --build-arg CAMPAIGNS_SLURM_SHA=dd27dd4817b0718687a53ec0218b18e8588d8b5a --build-arg DOCKER_REGISTRY=ghcr.io/eic/ --build-arg BUILDER_IMAGE=cuda_devel --build-arg RUNTIME_IMAGE=cuda_devel --build-arg INTERNAL_TAG=pipeline-23415161546 --build-arg ENV=cuda --build-arg SPACK_DUPLICATE_ALLOWLIST="epic|llvm|py-setuptools|py-urllib3" --build-context spack-environment=spack-environment --cache-from type=registry,ref=ghcr.io/eic/buildcache:eic_cuda-default-pr-opticks_revert-amd64 --cache-from type=registry,ref=ghcr.io/eic/buildcache:eic_cuda-default-master-amd64 --file containers/eic/Dockerfile --target final containers/eic

@plexoos
Copy link
Member

plexoos commented Mar 24, 2026

Hopefully, it is fixed in the new release:

#212
eic/eic-spack#859

@veprbl veprbl closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants