-
Notifications
You must be signed in to change notification settings - Fork 230
Detect change on network interface to update locators and scouting #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'new feature', 'documentation', 'enhancement', 'dependencies'} |
|
A few changes:
There's an additional caveat, the "reset" of the scouting routine may interrupt something important (e.g. the connection to a peer). |
5d2a194 to
3d7c115
Compare
3d7c115 to
8dc2681
Compare
On Unix systems, use netlink to detect added or delete IPv4 addresses to: * Renew the interface list. * Update the node locators. * Restart the scouting to use the new addresses/discard the old addresses. This is still quite hacky, with the following shortcommings: * We do not handle IPv6 addresses. * We perform the locator update and the scouting reset even if the new/old addresses are not used as per the configuration. * The code overall is not the best quality.
Remove the scouting reset upon interface change. This is in preparation of an improvemnt of the scouting update upon interface change.
8dc2681 to
8c686fe
Compare
434b925 to
1f07a8a
Compare
1f07a8a to
75d6d36
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
- Coverage 70.95% 70.88% -0.08%
==========================================
Files 364 366 +2
Lines 61491 61763 +272
==========================================
+ Hits 43633 43779 +146
- Misses 17858 17984 +126 ☔ View full report in Codecov by Sentry. |
When updating the locators after a network change, send the new locators to the routers and the peers if in linkstate mode.
|
this is quite important! |
On Unix systems, use netlink to detect added or delete IPv4 addresses to:
This is still quite hacky, with the following shortcomings:
This would solve #1823 (with the mentioned caveats).
Feel free to close this, I opened it more for reference and I might not update it.