Interceptor improvements #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add max buffered size during body interception - Handle body and head interception failures Motivation: The body and head interception API can be unified further more by providing a single interceptor instead of two interceptors. The current body transformation API assumes buffering and therefore uses buffer cumulation, therefore it should have an upper bound regarding this cumulation. The interceptor implementation does not handle failures such as a transformation failure or a buffer overflow.
Motivation: Currently body transformer are applied on the media type whatsoever. A body transformer should declare the list of media type it produces as well as indicate which media type it consumes. These should be taken in account when applying the body transformer or not on the proxied stream. Changes: Add a body transformer produces/consumes method. The generic proxy interceptor uses the produces/consumes to decide whether or not to apply the transformer based on the response accept header. The Body interface has been added a media type that indicates the media type of the body entity which can be used to match against transformers and also let the transformer set a body with a different media type.
Motivation: The design of BodyTransformer is synchronous as currently it only applies to buffering functions. We should make this contract asynchronous and move the synchronous part in the implementations we currently support. Changes: BodyTransform transforms Body->Future<Body> instead of Buffer->Buffer Synchronous transformations are moved to a BodyTransfomers class Buffering overflow moves to the synchronous transformer instead of being in the interceptor since now the interceptor only sees an asynchronous transformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.