Implement support for DNS over TCP fallback in Netty. #5555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azotcsit
force-pushed
the
4493_dns-over-tcp_v4.x
branch
2 times, most recently
from
daa79e4 to
deb7123
Compare
Motivation: Netty implemented a feature to support DNS over TCP fallback in case of a timeout for DNS over UDP (netty/netty#9127). This PR allows to enable that feature. Changes: Added retryWithTcpOnTimeout flag to AddressResolverOptions and corresponding classes.
azotcsit
force-pushed
the
4493_dns-over-tcp_v4.x
branch
from
deb7123 to
e37d583
Compare
|
Hi @vietj, I'd be very grateful if you could take a look at this PR and guide me on the next steps. I'm new to Vert.x contribution process, so any suggestions would be very welcomed. Thanks! |
|
can you test this new option ? |
|
@vietj I think I can test it manually, however it will take some time as the problem is not easily reproducible in our env. WRT unit testing, I'm not sure how to validate that TCP fallback happened. Could you please give me some references / suggestions on the best way to implement that? |
|
we could need to mock the TCP server and respond to the same traffic that a server does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #4493. The high-level idea is to support Netty feature to retry failed UDP DNS queries via TCP - netty/netty#9127.
I'm not sure about master branch, do I need to raise a separate PR for that?