Skip to content

refactor(projects): Unify linked projects modal table columns#1511

Open
ansonnchan wants to merge 5 commits intoeclipse-sw360:mainfrom
ansonnchan:refactor/unify-link-projects-modal
Open

refactor(projects): Unify linked projects modal table columns#1511
ansonnchan wants to merge 5 commits intoeclipse-sw360:mainfrom
ansonnchan:refactor/unify-link-projects-modal

Conversation

@ansonnchan
Copy link

Issue #1505

Hi @deo002 , I've opened a PR for the "link projects modal" subtask of this issue.

Scope covered:

  • src/components/sw360/LinkedProjectsModal/LinkProjectsModal.tsx
  • src/app/[locale]/projects/components/LinkProjects.tsx

Summary:

  • Unified duplicated linked-project table column logic used by both components
  • Added a shared column implementation file: src/components/sw360/LinkedProjectsModal/linkedProjectsColumns.tsx
  • Kept existing behavior as is

Validation done locally:

  • pnpm exec biome check
  • pnpm build

@ansonnchan ansonnchan force-pushed the refactor/unify-link-projects-modal branch 3 times, most recently from e13fb3b to dc8325f Compare March 4, 2026 06:43
@ansonnchan ansonnchan marked this pull request as draft March 4, 2026 06:45
@ansonnchan
Copy link
Author

I verified commit metadata is correct (author/committer: ananryry180@gmail.com, commit: dc8325f).
I’m currently fixing Eclipse account linkage for ECA and will update once validation recognizes my GitHub account (ansonnchan).

@ansonnchan ansonnchan force-pushed the refactor/unify-link-projects-modal branch from a8846b2 to 69a2403 Compare March 5, 2026 07:55
@ansonnchan ansonnchan marked this pull request as ready for review March 5, 2026 07:56
@ansonnchan
Copy link
Author

ansonnchan commented Mar 7, 2026

Added license header to new file in newest commit: 7f6e860

@amritkv amritkv self-assigned this Mar 10, 2026
@amritkv amritkv added needs code review needs codes review needs general test needs general test labels Mar 10, 2026
@amritkv
Copy link
Member

amritkv commented Mar 10, 2026

Hey @ansonnchan !
The issue linked to this PR i.e #1505, where the point 5 you were trying to solve, doesn't align with the expected solution.
The issue is to remove the duplicate component.
In simpler terms, there are 2 link projects modal where only one is sufficient. Try to remove one of them, and cascade these changes to all the places, wherever the link project modal is used.

Note : As the link project modal is being used more than one place, it would be great to keep the component under src/components/sw360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review needs codes review needs general test needs general test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants