Retire the stale SAC dependency from the css.swt test bundle#4139
Merged
Conversation
The production CSS bundles no longer reference SAC after the value-record migration. The only remaining org.w3c.css.sac trace was the uncompiled tkuiTestsToRefactor legacy tests and a matching Import-Package in the org.eclipse.e4.ui.tests.css.swt manifest. That folder is not on the build path, so it never ran as tests. Delete it and drop the Import-Package so the SAC library can leave the target platform.
Contributor
Contributor
Author
|
Before and during my work on the CSS engine I added lots of tests to ensure that I do not break existing functionality. These tests are outdated and test old API so I remove them. These are reference tests dead since 2008 (since 17 years) only touched recently by my global "update color constructors" sweep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the CSS value-record migration the production bundles no longer reference SAC. The only remaining
org.w3c.css.sactrace was thetkuiTestsToRefactorlegacy tests inorg.eclipse.e4.ui.tests.css.swtplus a matchingImport-Packagein its manifest. That folder is not on the build path (onlysrc/is compiled), so it never ran as tests.This deletes the folder and drops the SAC
Import-Package, which lets theorg.w3c.css.saclibrary leave the target platform once no bundle outside this repo needs it. Independent of the cascade work in #4122.