Inherit host control colors in content proposal popups#4137
Merged
vogella merged 1 commit intoJun 26, 2026
Merged
Conversation
Content proposal popups now fall back to the colors of the control they are attached to when the JFace CONTENT_ASSIST_* color preferences are unset. RCP applications that style their controls through SWT API, without configuring these JFace preferences, get matching popups for free. It also fixes the white completion popup in the dark-themed workspace selection dialog, which is shown before the workbench theme is applied.
vogella
force-pushed
the
content-assist-popup-inherit-colors
branch
from
7b6b721 to
1c7f5c9
Compare
Contributor
Contributor
Author
|
This is just a fallback scenario in case the color registry is not yet set, so all regular behavior should be unchanged. |
There was a problem hiding this comment.
Pull request overview
This PR improves theming consistency for JFace FieldAssist content proposal popups by inheriting the host control’s foreground/background colors when the CONTENT_ASSIST_* colors are not configured in the JFace color registry. This better aligns popup appearance with SWT-styled controls and avoids mismatched white popups in dark UI contexts (e.g., workspace selection dialog).
Changes:
- Make
ContentProposalAdapterproposal popup colors fall back to the host control’s foreground/background whenJFacePreferences.CONTENT_ASSIST_*_COLORis unset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content proposal popups now fall back to the host control's colors when
the JFace
CONTENT_ASSIST_*preferences are unset, instead of defaultingto white.
RCP applications that style their controls via SWT API get matching
popups for free, and the white completion popup in the dark workspace
selection dialog is fixed.