Skip to content

Clean Code for bundles/org.eclipse.jface.text#3293

Merged
akurtakov merged 1 commit into
masterfrom
clean-code/bundles/org.eclipse.jface.text
Oct 22, 2025
Merged

Clean Code for bundles/org.eclipse.jface.text#3293
akurtakov merged 1 commit into
masterfrom
clean-code/bundles/org.eclipse.jface.text

Conversation

@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions

github-actions Bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 24m 9s ⏱️ -17s
 8 229 tests ±0   7 980 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 607 runs  ±0  22 813 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit e21a637. ± Comparison against base commit da8753c.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 9 times, most recently from 41d9bee to 03683f1 Compare September 25, 2025 03:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 03683f1 to ab6b8d6 Compare September 26, 2025 03:28
@akurtakov

Copy link
Copy Markdown
Member

@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed?

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from ab6b8d6 to 88bee99 Compare September 27, 2025 03:25
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 88bee99 to d1391ba Compare September 27, 2025 11:15
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 4 times, most recently from 7ea3aa8 to 3bf0879 Compare October 2, 2025 03:31
@vogella

vogella commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 2 times, most recently from 5a9b96f to 2c6a902 Compare October 8, 2025 03:23
@vogella

vogella commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Ups, sorry, clicked the default (merge) instead of the rebase. I can update this later tonight and remove the merge commit.

@akurtakov is it possible to disable the "Update with merge" option from the webui?

@akurtakov

Copy link
Copy Markdown
Member

No idea .

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 47441f5 to 153addf Compare October 9, 2025 03:22
@vogella

vogella commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Has been updated by the bot

@vogella vogella force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 153addf to 4f86007 Compare October 9, 2025 22:11
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 7 times, most recently from f9afe16 to a57dc8b Compare October 18, 2025 03:23
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 3 times, most recently from 3670d9b to 124b7d7 Compare October 22, 2025 03:31
akurtakov added a commit to akurtakov/eclipse.platform.ui that referenced this pull request Oct 22, 2025
A prep step for
eclipse-platform#3293 .
Makes sure that comments are not lost.
akurtakov added a commit that referenced this pull request Oct 22, 2025
A prep step for
#3293 .
Makes sure that comments are not lost.
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 124b7d7 to e21a637 Compare October 22, 2025 09:48
@akurtakov akurtakov merged commit aa146c3 into master Oct 22, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.jface.text branch October 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants