Merged
Conversation
hbragge-acn
reviewed
Apr 29, 2025
Contributor
hbragge-acn
left a comment
hbragge-acn
left a comment
There was a problem hiding this comment.
Nice work! Added some minor comments
| @@ -0,0 +1,59 @@ | |||
| // Copyright 2025 Accenture. | |||
|
|
|||
| #ifndef GUARD_FE5C7F2F_D5EC_4301_BBAC_55D1A020394D | |||
Contributor
There was a problem hiding this comment.
We should use "#pragma once" instead of include guards now
| * Store a trace event with id argument. | ||
| * | ||
| * There are two types a frames: normal frames and extended frames. | ||
| * Each frames stores the relative time since the last tracing event. |
Contributor
There was a problem hiding this comment.
Each frames -> Each frame
| * | ||
| * There are two types a frames: normal frames and extended frames. | ||
| * Each frames stores the relative time since the last tracing event. | ||
| * If that time is too long for a normal frame, and extended frame will be used |
Contributor
There was a problem hiding this comment.
and extended -> an extended
doc/learning/tracing/index.rst
Outdated
| Once the trace buffer is full, the tracing will stop automatically. | ||
| You can use the `init()` method to start over with an empty trace buffer. | ||
|
|
||
| In order to trace their own custom events, users may use method `traceUser(uint8_t usrIdx)`. |
Contributor
There was a problem hiding this comment.
use method -> use the method
The tracing feature enables collection of scheduling events. This data can be used by tracing tools (e.g. babeltrace2) running on a host to visualize the kernel's inner workings and the behavior of its subsystems (e.g. when a task is switched in or out). Tracing events are stored in RAM in binary format and can later be converted to human readable format using trace_convert.py script or babeltrace2 with the bt_plugin_openbsw.py plugin. Signed-off-by: Marcin Wierzbicki <marcin.wierzbicki@accenture.com>
marcin-wierzbicki
force-pushed
the
cr-124650
branch
from
6241d01 to
5fbb378
Compare
hbragge-acn
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originates from CR #124650